Ticket #7 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

time check fails on update (solaris)

Reported by: oget Assigned to: skvidal
Priority: major Milestone:
Component: createrepo Version:
Keywords: Cc:

Description

Hi, In our port of createrepo/yum suite, we realized that the --update switch does not do what it is supposed to do and it regenerates the whole repo.

I found that the problematic line is in readMetadata.py, line 139

if st.st_mtime != mtime:

In solaris, st.st_mtime returns float, but mtime is always integer. Hence the comparison fails and metadata gets regenerated from scratch. The workaround (and maybe the solution?) is to change this line to

if int(st.st_mtime) != mtime:

I wanted to bring this to your attention, as you might want your code to be portable.

This is for version 0.9.8.

Cheers, oget

Change History

01/11/10 16:18:30 changed by skvidal

  • status changed from new to closed.
  • resolution set to fixed.

You're right and was fixed in git by another patch.

thanks